Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r77279256
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String reserve(DeploymentPlanner plannerToUse,
@BeanParam DeploymentPlan plan, E
boolean stop(String caller) throws ResourceUnavailableException,
CloudException;
/**
+ * Stop the virtual machine, optionally force
+ *
+ */
+ boolean stop(String caller, boolean forced) throws
ResourceUnavailableException, CloudException;
--- End diff --
@rhtyd since this PR adds new methods, let's not carry it forward. The
implementation of ``forceStop`` would end up passing ``true`` for the
``forced`` flag down the stack, but at least we are not expanding an
anti-pattern.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
