Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77635639
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCreateStoragePoolCommandWrapper.java
---
@@ -39,20 +41,35 @@
public Answer execute(final CreateStoragePoolCommand command, final
CitrixResourceBase citrixResourceBase) {
final Connection conn = citrixResourceBase.getConnection();
final StorageFilerTO pool = command.getPool();
+
try {
- if (pool.getType() == StoragePoolType.NetworkFilesystem) {
- citrixResourceBase.getNfsSR(conn,
Long.toString(pool.getId()), pool.getUuid(), pool.getHost(), pool.getPath(),
pool.toString());
- } else if (pool.getType() == StoragePoolType.IscsiLUN) {
- citrixResourceBase.getIscsiSR(conn, pool.getUuid(),
pool.getHost(), pool.getPath(), null, null, false);
- } else if (pool.getType() == StoragePoolType.PreSetup) {
- } else {
- return new Answer(command, false, "The pool type: " +
pool.getType().name() + " is not supported.");
+ if (command.getCreateDatastore()) {
--- End diff --
Yes, CloudStack does allow an admin to specify an IQN (and other storage
info) when adding primary storage that leads to the creation of an SR for you.
To my knowledge, this is not the case on, say, ESXi/vSphere, though. In
that case, you have to create your datastore before adding it to CloudStack as
primary storage.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
