Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1678#discussion_r80064777
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsVpcPhysicalTopologyConfigCommandWrapper.java
---
@@ -36,7 +36,7 @@
@Override
public Answer execute(final OvsVpcPhysicalTopologyConfigCommand
command, final LibvirtComputingResource libvirtComputingResource) {
try {
- final Script scriptCommand = new
Script(libvirtComputingResource.getOvsTunnelPath(),
libvirtComputingResource.getTimeout(), s_logger);
+ final Script scriptCommand = new
Script(libvirtComputingResource.getOvsTunnelPath(),
libvirtComputingResource.getTimeout().getMillis(), s_logger);
--- End diff --
Please consider adding an overridden version of the `Script(String, int,
Logger)` constructor that accepts `Duration` to encapsulate this type
conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
