Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1678#discussion_r80408774 --- Diff: core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java --- @@ -374,9 +375,9 @@ private Answer execute(AggregationControlCommand cmd) { FileConfigItem fileConfigItem = new FileConfigItem(VRScripts.CONFIG_CACHE_LOCATION, cfgFileName, sb.toString()); ScriptConfigItem scriptConfigItem = new ScriptConfigItem(VRScripts.VR_CFG, "-c " + VRScripts.CONFIG_CACHE_LOCATION + cfgFileName); // 120s is the minimal timeout - int timeout = answerCounts * _eachTimeout; - if (timeout < 120) { - timeout = 120; + Duration timeout = _eachTimeout.withDurationAdded(_eachTimeout.getStandardSeconds(), answerCounts); --- End diff -- Why use `withDurationAdded` rather `multipliedBy`? Passing `_eachTimeout` into the method is an indication that `multipliedBy` may be a more concise expression of intent.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---