Github user singalrahul commented on the issue:

    https://github.com/apache/cloudstack/pull/1578
  
    LGTM
    
    After incorporating review comment, the marvin test goes fine :+1: 
    
    Verify InternalDns on Isolated Network ... === TestName: 
test_01_Isolated_Network_with_zone | Status : SUCCESS ===
    ok
    Verify InternalDns on Isolated Network with ping by hostname ... === 
TestName: test_02_Isolated_Network | Status : SUCCESS ===
    ok
    Verify update NetworkDomain for InternalDns on Isolated Network ... === 
TestName: test_03_Update_Network_with_Domain | Status : SUCCESS ===
    ok
    Verify update NetworkDomain for InternalDns on Isolated Network ... === 
TestName: test_04_Update_Network_with_Domain | Status : SUCCESS ===
    ok
    Verify InternalDns on VPC Network ... === TestName: 
test_05_VPC_Network_With_InternalDns | Status : SUCCESS ===
    ok
    Verify InternalDns on VPC Network by ping with hostname ... === TestName: 
test_06_VPC_Network_With_InternalDns | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 6 tests in 3941.529s
    
    OK
    [runinfo.txt](https://github.com/apache/cloudstack/files/522295/runinfo.txt)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to