GitHub user marcaurele opened a pull request:

    https://github.com/apache/cloudstack/pull/1723

    Fix GroupBy (+ having) condition and tests

    The GroupBy + having isn't used currently in the code but was not clean. It 
removes unused arguments and variables and adds a test based on a DAO to show a 
full example of how to use it.
    
    Signed-off-by: Marc-Aurèle Brothier <m...@brothier.org>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/exoscale/cloudstack fix/group-by

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1723.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1723
    
----
commit 2ee97e8fa5c179bb48fb121ce6422df6d0794154
Author: Marc-Aurèle Brothier <m...@brothier.org>
Date:   2016-10-21T12:43:11Z

    Fix GroupBy (+ having) condition and tests
    
    The GroupBy + having isn't used currently in the code but was not clean.
    It removes unused arguments and variables and adds a test based on a DAO
    to show a full example of how to use it.
    
    Signed-off-by: Marc-Aurèle Brothier <m...@brothier.org>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to