Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1727#discussion_r84841681
  
    --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
    @@ -610,7 +615,11 @@ public UserVm revertToSnapshot(Long vmSnapshotId) 
throws InsufficientCapacityExc
                 VmWorkJobVO placeHolder = null;
                 placeHolder = createPlaceHolderWork(vmSnapshotVo.getVmId());
                 try {
    -                return orchestrateRevertToVMSnapshot(vmSnapshotId);
    +                UserVm revertedVM = 
orchestrateRevertToVMSnapshot(vmSnapshotId);
    +
    +                updateUserVmServiceOffering(revertedVM, vmSnapshotVo);
    --- End diff --
    
    Better to put updateUserVmServiceOffering() call inside 
orchestrateRevertToVMSnapshot() as orchestrate is called from multiple places. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to