Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r89576730
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn,
final String path) {
PBD pbd = null;
try {
- final String srname = hypervisorResource.getHost().getUuid() +
path.trim();
-
- final Set<SR> srs = SR.getByNameLabel(conn, srname);
-
- if (srs != null && !srs.isEmpty()) {
- return srs.iterator().next();
+ final String srname = path.trim();
--- End diff --
@abhinandanprateek could there be a case that after upgrade
SR.getByNameLabel will fail as the srname has changed? I would say let's not
break the naming convention if it's used in/by external resources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
