Can you remove that column addition in the alter statement and see if the upgrade continues?
Do you recall installing any customer version of ACS that may have included DB schema patches? ________________________________ From: Boris Stoyanov <boris.stoya...@shapeblue.com> Sent: Wednesday, December 14, 2016 6:31 AM To: dev@cloudstack.apache.org Subject: Re: [VOTE] Apache Cloudstack 4.9.1.0 (RC1) Hi, We’ve currently have a plan for upgrade testing covering the following scenarios: I’ve tried upgrading from 4.5.2.2 to 4.9.1, but got the following exception: 2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- Schema upgrade from 4.5.1 to 4.6.0 2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) -- 2016-12-13 14:37:28,128 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) ALTER TABLE `cloud`.`snapshots` ADD COLUMN `min_iops` bigint(20) unsigned COMMENT 'Minimum IOPS' 2016-12-13 14:37:28,135 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) Error executing: ALTER TABLE `cloud`.`snapshots` ADD COLUMN `min_iops` bigint(20) unsigned COMMENT 'Minimum IOPS' 2016-12-13 14:37:28,135 ERROR [c.c.u.d.ScriptRunner] (main:null) (logid:) com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate column name 'min_iops' 2016-12-13 14:37:28,136 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) (logid:) Unable to execute upgrade script: /usr/share/cloudstack-management/setup/db/schema-452to460.sql com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Duplicate column name 'min_iops' at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185) at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87) We’re currently having a plan to cover upgrade testing to 4.9.1 from 4.3, 4.5.2.2, 4.6.0. I’d love to continue with testing these upgrade scenarios once we fix the issue. Currently also we’re executing component tests against the following combinations: [KVM] MS CentOS68 + KVM hosts CentOS68 MS CentOS72 + KVM hosts CentOS72 [VMware] MS CentOS68 + VMware55u3 MS CentOS68 + VMware60u2 MS CentOS68 + VMware65 MS CentOS72 + VMware55u3 MS CentOS72 + VMware60u2 MS CentOS72 + VMware65 [XenServer] MS CentOS68 + XenServer62sp1 MS CentOS68 + XenServer65sp1 MS CentOS72+ XenServer65sp1 *Once we get 4.9.1 we’re looking fw to test XenServer 7 as well, as part of 4.9.2.0 Smoke tests has passed on KVM, VMware and XenServer hosts with CentOS6 and CentOS7 MS. Thanks, boris.stoya...@shapeblue.com www.shapeblue.com<http://www.shapeblue.com> [http://shapeblue.com/wp-content/uploads/2014/03/sungardonline1.jpg]<http://www.shapeblue.com/> ShapeBlue - The CloudStack Company<http://www.shapeblue.com/> www.shapeblue.com Offers seamless Container-as-a-Service without disruption to user experience or business process Sevilla, Spain -- 17 November 2016 -- ShapeBlue, the 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue > On Dec 14, 2016, at 12:18 PM, Murali Reddy <muralimmre...@gmail.com> wrote: > > +1 > > Based on smoke test results [1] and below tests run manually on VMware > deployment > > - VM life cycle operations > - network life cycle operations > - verified source NAT, static NAT, PF, LB, VPC internal LB, network ACL, > firewall > - upgrade from 4.9 and 4.5.2 > > > IMO issue raised by Milamber should be fixed on 4.10. If the functionality > does not exist in 4.9, then no need to have schema change in 4.8 to 4.9 > upgrade path. > > Redundant VPC VR functionality appears to be broken from last few releases. > In my testing noticed both the VR getting stuck in backup or in unknown > state. RVR test failed consistently in smoke tests [1]. We should at least > release note them as known issues. I will check existing bugs and open new > one if necessary. > > [1] https://github.com/apache/cloudstack/pull/1753 [https://avatars1.githubusercontent.com/u/95203?v=3&s=400]<https://github.com/apache/cloudstack/pull/1753> [4.9] Latest health test run by rhtyd · Pull Request #1753 · apache/cloudstack<https://github.com/apache/cloudstack/pull/1753> github.com Dummy PR to trigger tests on latest 4.9 branch @blueorangutan package > > > > > On 14/12/16, 12:32 AM, "Milamber" <milam...@apache.org> wrote: > >> >> Hello, >> >> I'm not sure, but perhaps we have an 'indirect' blocker for 4.9.1.0 RC1. >> >> Currently the upgrade from 4.9.1.0 RC1 to 4.10.0.0 SNAPSHOT don't works >> because the schema-481to490.sql in the 4.9.1.0 / 4.9 doesn't contains >> the commit of CLOUDSTACK-9438 (2e77496601ab5420723ce8b955b3960faaba7d5c). >> (this commit is currently in master) >> >> When you try to make the upgrade you have this error: "Unknown column >> 'image_store_details.display' in 'field list'" >> see: https://issues.apache.org/jira/browse/CLOUDSTACK-9671 >> >> Currently there have 2 diff between the schema-481to490.sql in 4.9.1.0 >> RC1 (and 4.9 branch) and master branch. >> >> What is your opinion: blocker or not? >> >> Just copy the 2 sql request inside the schema-4910to41000.sql file (but >> the commit 2e77496601ab5420723ce8b955b3960faaba7d5c contains other >> modified files)? >> >> Milamber >> >> >> >> $ diff ./setup/db/db/schema-481to490.sql /tmp/MASTER-schema-481to490.sql >> 547a548,552 >>> >>> ALTER TABLE `cloud`.`image_store_details` CHANGE COLUMN `value` >> `value` VARCHAR(255) NULL DEFAULT NULL COMMENT 'value of the detail', >> ADD COLUMN `display` tinyint(1) NOT >>> NULL DEFAULT '1' COMMENT 'True if the detail can be displayed to the >> end user' AFTER `value`; >>> >>> ALTER TABLE `snapshots` ADD COLUMN `location_type` VARCHAR(32) >> COMMENT 'Location of snapshot (ex. Primary)'; >> >> >> >> >> >> On 12/12/2016 21:36, Milamber wrote: >>> Hello, >>> >>> My vote +1 (binding) >>> >>> Tests are passed on a virtual topology of servers (CS over CS) >>> (1mgr+2nodes+1nfs) : >>> >>> 1/ Fresh install of 4.9.1.0 RC1 (adv net) on Ubuntu 14.04.5 + KVM + >>> NFS : OK >>> Some standard tests with success (create vm, migration, HA, create >>> networks, create user, create ssh key, destroy vm, register template, >>> create snapshot, restore snapshot, create template, ip association, ip >>> release, static nat, firewall rule) >>> Some tests with cloudstack ansible module with success too (create >>> network, register templates, create vm, ip, firewall rule) >>> >>> 2/ Test upgrade from 4.8.1 to 4.9.1.0 RC1 : OK >>> >>> 3/ Test upgrade from 4.8.2 RC1 to 4.9.1.0 RC1 : don't works (expected) >>> >>> 4/ Tests of all localization Web UI for 4.9.1.0 RC1: >>> Localization works well except Spanish (not a blocker to release): the >>> Web UI display partially the localization strings due of one bad >>> carriage return in the label >>> message.installWizard.copy.whatIsCloudStack string (from Transifex). >>> This is the same issue that the 4.8.2 RC1. >>> >>> >>> Perhaps add in the Release notes this Spanish l10n issue. >>> >>> Thanks to the RM. >>> >>> Milamber >>> >>> >>> >>> On 10/12/2016 03:11, Rohit Yadav wrote: >>>> Hi All, >>>> >>>> I've created a 4.9.1.0 release, with the following artifacts up for a >>>> vote: >>>> >>>> Git Branch and Commit SH: >>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.1.0-RC20161210T0838 >>>> >>>> Commit: af2679959b634d095b93b8265c6da294d360065d >>>> >>>> List of changes: >>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.9.1.0-RC20161210T0838 >>>> >>>> >>>> Source release (checksums and signatures are available at the same >>>> location): >>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.9.1.0/ >>>> >>>> PGP release keys (signed using 0EE3D884): >>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS dist.apache.org<https://dist.apache.org/repos/dist/release/cloudstack/KEYS> dist.apache.org This file contains the PGP keys of various developers. Users: pgp KEYS gpg --import KEYS Developers: pgp -kxa and append it to this file. >>>> >>>> Vote will be open for 120 hours, considering the process started >>>> during the >>>> weekends, and will end on 14 Dec 2016 end of the day. >>>> >>>> For sanity in tallying the vote, can PMC members please be sure to >>>> indicate >>>> "(binding)" with their vote? >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove (and reason why) >>>> >>>> Regards. >>>> >>> >>> >> >