GitHub user sateesh-chodapuneedi opened a pull request:
https://github.com/apache/cloudstack/pull/1861
CLOUDSTACK-9698 Make hardcorded wait timeout for NIC adapter hotplug as
configurable
Jira
===
CLOUDSTACK-9698 Make hardcoded wait timeout for NIC adapter hotplug as
configurable
Description
=========
Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as
configurable will be helpful for admins in such scenarios.
Also in future if VMware introduces new NIC adapter types which may take
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.
Fix
===
Introduce new configuration parameter (via ConfigKey)
"vmware.nic.hotplug.wait.timeout" which is "Wait timeout (milli seconds) for
hot plugged NIC of VM to be detected by guest OS." as fallback instead of hard
coded timeout, to ensure flexibility for admins given the listed scenarios
above.
Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sateesh-chodapuneedi/cloudstack
pr-cloudstack-9698
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1861.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1861
----
commit 2ea7aadbac386f4d3a0e0062e1042e4266c24e91
Author: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
Date: 2016-12-23T00:51:04Z
CLOUDSTACK-9698 Make the wait timeout for NIC adapter hotplug as
configurable
Currently ACS waits for 15 seconds (hard coded) for hot-plugged NIC in VR
to get detected by guest OS.
The time taken to detect hot plugged NIC in guest OS depends on type of NIC
adapter like (E1000, VMXNET3, E1000e etc.)
and guest OS itself. In uncommon scenarios the NIC detection may take
longer time than 15 seconds,
in such cases NIC hotplug would be treated as failure which results in VPC
tier configuration failure.
Alternatively making the wait timeout for NIC adapter hotplug as
configurable will be helpful for admins in such scenarios.
Also in future if VMware introduces new NIC adapter types which may take
time to get detected by guest OS, it is good to have flexibility of
configuring the wait timeout as fallback mechanism in such scenarios.
Signed-off-by: Sateesh Chodapuneedi <sateesh.chodapune...@accelerite.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
