Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1735#discussion_r94555654
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -526,16 +529,18 @@ public static DataStoreRole getDataStoreRole(Snapshot
snapshot, SnapshotDataStor
}
long storagePoolId = snapshotStore.getDataStoreId();
- DataStore dataStore = dataStoreMgr.getDataStore(storagePoolId,
DataStoreRole.Primary);
+ if (snapshotStore.getState() != null && !
snapshotStore.getState().equals(ObjectInDataStoreStateMachine.State.Destroyed))
{
--- End diff --
As pointed out by @mike-tutkowski store cannot be destroyed if there are
snapshots. Also that enum is meant for snapshot (and entities like that) and
not for snapshot store.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
