Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1906#discussion_r100281158
  
    --- Diff: 
plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java
 ---
    @@ -156,7 +153,7 @@ public HostVO createHostVOForDirectConnectAgent(HostVO 
host, StartupCommand[] st
     
         @Override
         public DeleteHostAnswer deleteHost(HostVO host, boolean isForced, 
boolean isForceDeleteStorage) throws UnableDeleteHostException {
    -        return new DeleteHostAnswer(true);
    +        return null;
    --- End diff --
    
    @syed I am not sure if this is used or maintained by anyone. But the right 
fix may be to use some checks to return a valid answer or null. How is this 
handled in some of the other network elements?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to