Github user niteshsarda commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1972#discussion_r103138362
  
    --- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java 
---
    @@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl() {
             return listBy(sc);
         }
     
    +    @Override
    +    public boolean isLoadBalancerRulesMappedToVmGuestIp(long instanceId, 
String instanceIp, long networkId, FirewallRule.Purpose purpose)
    +    {
    +        SearchBuilder<LoadBalancerVMMapVO> lbVmMapSearch = 
_loadBalancerVMMapDao.createSearchBuilder();
    +        lbVmMapSearch.and("instanceIp", 
lbVmMapSearch.entity().getInstanceIp(),SearchCriteria.Op.EQ);
    +        lbVmMapSearch.and("instanceId", 
lbVmMapSearch.entity().getInstanceId(), SearchCriteria.Op.EQ);
    +
    +        SearchBuilder<FirewallRuleVO> firewallRuleIdSearch = 
_firewallRulesDao.createSearchBuilder();
    --- End diff --
    
    @ustcweizhou  : As per suggestion, I have made changes. Please check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to