Github user rhtyd commented on the issue:

    https://github.com/apache/cloudstack/pull/1768
  
    @marcaurele I appreciate the cleanup, it should have been like this from 
the beginning but since we've the workflow to execute all the upgrades first 
and then the cleanup. In 
`https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-481to490-cleanup.sql`
 the views are executed at the end because certain columns are added by the 
java based upgrade path and views can only access them after the 
script/java-based-upgrade is complete. I think with this change future db 
upgrade paths need to written carefully.
    
    I've no objections with the overall goal to cleanup the sequence logic, 
though I have a concern that this might cause upgrade regressions in some 
environments as writing upgrade validation tests may not be possible. /cc 
@DaanHoogland @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to