Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1768#discussion_r103394277
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
---
@@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion,
CloudStackVersion currentVer
}
upgrade.performDataMigration(conn);
- boolean upgradeVersion = true;
-
- if (upgrade.getUpgradedVersion().equals("2.1.8")) {
--- End diff --
I thought that anything older than 4.x should be removed. The simulator and
DB schema create a structure based on 4.0.0 or 4.1.0 if I recall correctly.
I initially added another commit (removed now) which was only leaving
upgrade paths from version 4.0.0. That can be done later, and I think it would
be a good cleanup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
