Github user bvbharatk commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/837#discussion_r106088915
  
    --- Diff: engine/components-api/src/com/cloud/agent/AgentManager.java ---
    @@ -141,7 +142,7 @@
     
         public void pullAgentOutMaintenance(long hostId);
     
    -    boolean reconnect(long hostId);
    +    void reconnect(long hostId) throws CloudRuntimeException, 
AgentUnavailableException;
    --- End diff --
    
    @rafaelweingartner
    When i said they will have to catch i meant, When a method declaration has 
one or more exceptions defined using throws clause then the method-call must 
handle all the defined exceptions. If he wants to handle it he will have to 
catch it, if he dose not want to handle he can bubble it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to