Github user jayapalu commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1908#discussion_r110082664
  
    --- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
    @@ -1764,9 +1765,12 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
                     }
                     nicNum = 
broadcastUriAllocatedToVM.get(ip.getBroadcastUri());
     
    -                if (numOfIps == 1 && !ip.isAdd()) {
    -                    vifHotUnPlug(conn, routerName, ip.getVifMacAddress());
    -                    networkUsage(routerIp, "deleteVif", "eth" + nicNum);
    +                if (lastIp != null && lastIp.equalsIgnoreCase("true") && 
!ip.isAdd()) {
    --- End diff --
    
    In CitrixresourceBase StringUtils is used from the  
com.cloud.utils.StringUtils. So using  StringUtils from java.lang will be 
ambiguous.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to