DaanHoogland commented on a change in pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used URL: https://github.com/apache/cloudstack/pull/1302#discussion_r113907617
########## File path: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java ########## @@ -404,4 +410,46 @@ public void testConfigNestedHVSupportFlagFalse() throws Exception{ verify(vmMo, never()).getRunningHost(); } + @Test + public void testComposeVmNames() throws Exception{ Review comment: i agree, let's test as little as possible per test ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services