Hi Rohit, Indeed.
I was about to write a comment on his review. Funny that in 2015 nobody, not even I who wrote the code, noticed. :) Cheers, Wilder > On 14 Feb 2018, at 11:40, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > > ... for reference, the current code: > https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ#L29 > > <https://github.com/apache/cloudstack/blob/4.11/systemvm/debian/opt/cloud/templates/check_heartbeat.sh.templ#L29> > > > > - Rohit > <https://cloudstack.apache.org/> > > > rohit.ya...@shapeblue.com <mailto:rohit.ya...@shapeblue.com> > www.shapeblue.com <http://www.shapeblue.com/> > @shapeblue > > > From: Rohit Yadav > Sent: Wednesday, February 14, 2018 11:39:24 AM > To: Jayakarteek Vasana; dev@cloudstack.apache.org; > wilder.rodrig...@ekholabs.ai > Cc: Jayapal Uradi > Subject: Re: Reg CLOUDSTACK-8616 > > Hi Jayakarteek, > > I think you've indeed found a bug, please submit a PR against 4.11 changing > the difference (current - last, not last - current): > > > > - Rohit > <https://cloudstack.apache.org/> > > > From: Jayakarteek Vasana <jayakarteek_vas...@accelerite.com> > Sent: Wednesday, February 14, 2018 7:49:23 AM > To: dev@cloudstack.apache.org; wilder.rodrig...@ekholabs.ai; Rohit Yadav > Cc: Jayapal Uradi > Subject: Reg CLOUDSTACK-8616 > > Hi, > > For CLOUDSTACK-8616(https://issues.apache.org/jira/browse/CLOUDSTACK-8616) , > changes were made in check_heartbeat.sh.tmpl > > Logic was changed on how the diff time is verified, with the changes the IF > condition ( last time will always be smaller than this time) will fail every > time and the ELSE log will fill the disk space. > > > So can someone check and confirm the logic for the change and whether the > logs are needed in the else part > > https://github.com/apache/cloudstack/pull/587/files#diff-002a85328505af2975427d354a11dbff > > <https://github.com/apache/cloudstack/pull/587/files#diff-002a85328505af2975427d354a11dbff> > > --Jayakarteek > > DISCLAIMER > ========== > This e-mail may contain privileged and confidential information which is the > property of Accelerite, a Persistent Systems business. It is intended only > for the use of the individual or entity to which it is addressed. If you are > not the intended recipient, you are not authorized to read, retain, copy, > print, distribute or use this message. If you have received this > communication in error, please notify the sender and delete all copies of > this message. Accelerite, a Persistent Systems business does not accept any > liability for virus infected mails.
