rhtyd commented on issue #99: [WIP] - Recurring Volume Snapshot Custom Action 
Form
URL: https://github.com/apache/cloudstack-primate/pull/99#issuecomment-574046988
 
 
   @utchoang reviewed, LGTM except for this few issues:
   1. Please always checkout new work/branch from origin/master, otherwise the 
PRs will have commits from other PRs/branches and will cause difficulties in 
reviewing them. I've fixed it manually for at least two PRs for now.
   
   2. When I open the recurring action form the first time, I'm unable to list 
the timezones:
   ![Screenshot from 2020-01-14 
13-03-55](https://user-images.githubusercontent.com/95203/72323812-94c09280-36cf-11ea-9835-ac7666cb4631.png)
   
   I've moved the timezone file/folder under utils and changed the import 
paths. It's also okay if instead of resolve/importing the json, you want to 
consume it as a static object/map.
   
   3. While you're at it, can you also fix the createSnapshot form which takes 
in tags, which is not supported out of the box:
   ![Screenshot from 2020-01-14 
13-10-53](https://user-images.githubusercontent.com/95203/72323947-e6691d00-36cf-11ea-9c99-5c4f017ccf04.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to