shwstppr commented on a change in pull request #272: view: role based routing
for domain, zone in info
URL: https://github.com/apache/cloudstack-primate/pull/272#discussion_r409992558
##########
File path: src/components/view/InfoCard.vue
##########
@@ -419,7 +419,7 @@
<div class="resource-detail-item__label">{{ $t('zone') }}</div>
<div class="resource-detail-item__details">
<a-icon type="global" />
- <router-link v-if="!resource.zoneid.includes(',')" :to="{ path:
'/zone/' + resource.zoneid }">{{ resource.zonename || resource.zoneid
}}</router-link>
+ <router-link v-if="!resource.zoneid.includes(',') &&
this.isAdmin()" :to="{ path: '/zone/' + resource.zoneid }">{{ resource.zonename
|| resource.zoneid }}</router-link>
Review comment:
@rhtyd how to check that?
Like for zone, we have a link like
`http://localhost:5050/#/zone/00bef679-f1b8-4cfa-95de-c1e9ee098823`. Can we
somehow ascertain this will return 404 because zone does actually exist and
only logged-in account doesn't have the privilege to see info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
