davidjumani commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r437362987
##########
File path: src/locales/en.json
##########
@@ -29,6 +29,7 @@
"inline": "Inline",
"label.about": "About",
"label.about.app": "About CloudStack",
+"label.accept": "Accept",
Review comment:
https://github.com/apache/cloudstack-primate/blob/master/src/views/offering/AddNetworkOffering.vue#L108
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
Done!
##########
File path: src/views/storage/ResizeVolume.vue
##########
@@ -24,7 +24,7 @@
initialValue: selectedDiskOfferingId,
rules: [{ required: true, message: 'Please select an option' }]}]"
:loading="loading"
- :placeholder="$t('label.offering.type')"
+ :placeholder="$t('label.diskoffering.type')"
Review comment:
Done
##########
File path: src/locales/en.json
##########
@@ -1426,6 +1432,7 @@
"label.portableipaddress": "Portable IPs",
"label.portforwarding": "Port Forwarding",
"label.powerstate": "Power State",
+"label.preferred": "Prefered",
Review comment:
https://github.com/apache/cloudstack-primate/blob/master/src/views/offering/AddComputeOffering.vue#L434
##########
File path: src/locales/en.json
##########
@@ -1539,6 +1549,7 @@
"label.region": "Region",
"label.region.details": "Region details",
"label.reinstall.vm": "Reinstall VM",
+"label.reject": "Reject",
Review comment:
Was reject itself, but as an inline string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
