rhtyd commented on a change in pull request #534:
URL: https://github.com/apache/cloudstack-primate/pull/534#discussion_r454099330
##########
File path: src/views/network/IngressEgressRuleConfigure.vue
##########
@@ -79,9 +79,9 @@
size="small"
style="overflow-y: auto"
:columns="columns"
- :dataSource="rules"
+ :dataSource="rules.slice(pagesize*(page - 1), Math.min( rules.length,
pagesize*page))"
Review comment:
Does the API not support pagination? Otherwise, I would expect to simply
give all the datasource (not a slice) and instead use table's own pagination
than an explicit one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
