rhtyd commented on a change in pull request #541:
URL: https://github.com/apache/cloudstack-primate/pull/541#discussion_r454802473
##########
File path: src/components/view/ListView.vue
##########
@@ -82,7 +82,8 @@
<router-link :to="{ path: $route.path + '/' + record.id }">{{ text
}}</router-link>
</a>
<span slot="username" slot-scope="text, record" href="javascript:;">
- <router-link :to="{ path: '/accountuser', query: { username:
record.username, domainid: record.domainid } }"
v-if="$store.getters.userInfo.roletype !== 'User'">{{ text }}</router-link>
+ <router-link :to="{ path: $route.path + '/' + record.id }"
v-if="['/accountuser', '/vpnuser'].includes($route.path)">{{ text
}}</router-link>
+ <router-link :to="{ path: '/accountuser', query: { username:
record.username, domainid: record.domainid } }"
v-else-if="$store.getters.userInfo.roletype !== 'User'">{{ text }}</router-link>
Review comment:
We'll have to test various views because of this, cannot merge without
testing all list views (or search for views with columns having 'username')
@davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
