DaanHoogland commented on code in PR #315: URL: https://github.com/apache/cloudstack-documentation/pull/315#discussion_r1224018203
########## source/plugins/cloudstack-kubernetes-service.rst: ########## @@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input, - **name** (name for the Kubernetes cluster; Required) -- **description** (description for the Kubernetes cluster; Required) +- **description** (description for the Kubernetes cluster) Review Comment: the png still shows the red star for required . can you update that as well? ########## source/plugins/cloudstack-kubernetes-service.rst: ########## @@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input, - **name** (name for the Kubernetes cluster; Required) -- **description** (description for the Kubernetes cluster; Required) +- **description** (description for the Kubernetes cluster) - **zoneid** (availability zone in which Kubernetes cluster to be launched; Required) -- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required) -- **serviceofferingid** (the ID of the service offering for the virtual machines in the cluster; Required) +- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required for CloudManaged clusters) Review Comment: is "CloudManaged" the right term? we could be looking at other SDI managed clusters as well and these would not be CloudManaged from our perspective. I think "CloudStack managed" would be a better term. ########## source/plugins/cloudstack-kubernetes-service.rst: ########## @@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or via the UI. User will be createKubernetesCluster API can be used to create new Kubernetes cluster. It takes following parameters as input, - **name** (name for the Kubernetes cluster; Required) -- **description** (description for the Kubernetes cluster; Required) +- **description** (description for the Kubernetes cluster) - **zoneid** (availability zone in which Kubernetes cluster to be launched; Required) -- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required) -- **serviceofferingid** (the ID of the service offering for the virtual machines in the cluster; Required) +- **kubernetesversionid** (Kubernetes version with which cluster to be launched; Required for CloudManaged clusters) Review Comment: addendum I see that the term is explained further on. I think it should be explained at first use. (not sure if we have a glosary this would fit into) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
