davidjumani commented on code in PR #53: URL: https://github.com/apache/cloudstack-terraform-provider/pull/53#discussion_r1234155294
########## README.md: ########## @@ -48,9 +48,14 @@ $ make build $ ls $GOPATH/bin/terraform-provider-cloudstack ``` Once the build is ready, you have to copy the binary into Terraform locally (version appended). -On Linux this path is at ~/.terraform.d/plugins, and on Windows at %APPDATA%\terraform.d\plugins. + +On Linux and Mac this path is at ~/.terraform.d/plugins, +On Windows at %APPDATA%\terraform.d\plugins, + ```sh -$ ls ~/.terraform.d/plugins/registry.terraform.io/cloudstack/cloudstack/0.4.0/linux_amd64/terraform-provider-cloudstack_v0.4.0 +$ cd ~ +$ mkdir -p .terraform.d/plugins/localdomain/provider/cloudstack/0.4.0/linux_amd64 Review Comment: ```suggestion $ mkdir -p ~/.terraform.d/plugins/localdomain/provider/cloudstack/0.4.0/linux_amd64 ``` Would be better to do it this way rather than chaning the current dir the user might be in ########## README.md: ########## @@ -48,9 +48,14 @@ $ make build $ ls $GOPATH/bin/terraform-provider-cloudstack ``` Once the build is ready, you have to copy the binary into Terraform locally (version appended). -On Linux this path is at ~/.terraform.d/plugins, and on Windows at %APPDATA%\terraform.d\plugins. + +On Linux and Mac this path is at ~/.terraform.d/plugins, +On Windows at %APPDATA%\terraform.d\plugins, + ```sh -$ ls ~/.terraform.d/plugins/registry.terraform.io/cloudstack/cloudstack/0.4.0/linux_amd64/terraform-provider-cloudstack_v0.4.0 +$ cd ~ +$ mkdir -p .terraform.d/plugins/localdomain/provider/cloudstack/0.4.0/linux_amd64 Review Comment: ```suggestion $ mkdir -p ~/.terraform.d/plugins/localdomain/provider/cloudstack/0.4.0/linux_amd64 ``` Would be better to do it this way rather than changing the current dir the user might be in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
