I have been eyeing it :-) because I think it is a major bug as well. But I decided that I knew too little about the consequences of your fix to apply it so shortly before the release.
So, unless another committer is willing to take the risk I would suggest we postpone this one until after the release. Unico JD Daniels wrote: > > Sorry to butt in guys :) > > But I was wondering if anyone could commit the patch for bug 26854 > > (Flow redirecting) > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26854 > > I am pretty sure it will fix 26571, and maybe 25437 and 22132. > > I am cvs illiterate, and can't figure out how to patch my own > copy here :( > > (I am only yapping cause i got all excited when it looked > like the release was going to be postphoned) > > JD > > Carsten Ziegeler wrote: > > > Unico Hommes wrote: > > > >>Yeah, the confusion with the memory bug was partly due to me. > >>After your original fix that still had a problem with the reader I > >>introduced the bug again when I tried to fix that. > >> > >>I agree that your latest fix should definitely work. In fact I took > >>the opertunity to install anteater and whereas before I > could run the > >>test script for this bug 4300 times before memory creeped > up to 115MB > >>I am now at iteration number 5500 and seeing a stable 50MB's. > >> > >>I haven't yet voted, but +1 for releasing! > >> > > > > Thanks Unico for the info! > > > > So, Reinhard and Joerg, what do you think? > > > > Carsten > > > > > >>Carsten Ziegeler wrote: > >> > >>>To increase the confusion :) I think we should stick to the code > >>>freeze as I see the chance for a release tomorrow. > >>> > >>>As far as I see it, we have the vetos from Reinhard and > >> > >>Joerg (Vadim > >> > >>>revoked), and it seems that these vetos stand and fall with > >> > >>the memory > >> > >>>leak bug, so all we have to do is: fix the bug, revoke the > >> > >>vetos, do > >> > >>>the release. > >>> > >>>I just committed a fix for the bug which imho should work. > >> > >>So we only > >> > >>>need one to cross-check this. > >>> > >>>(I really start to like calling out "code freeze", "end of code > >>>freeze" and repeating this over and over again) > >>> > >>>Carsten > >>> > >>> > >>> > >> > >> > > > > > > > >