DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=30356>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=30356 CIncludeTransformer + event aware caching ------- Additional Comments From [EMAIL PROTECTED] 2004-08-12 11:21 ------- Hi Unico, my apologies for the silence on my part. I've been under a little pressure to get my patch going, and I put your request on the backburner, which was rude. So I appreciate you still contributing your work to this thread. (and drudging through my source code!) Your IncludeTransformer class looks great. It's certainly much tidier than my patch, and, I think, provides the same functionality. I think I got a bit distracted by the helper cache classes (which I'm not yet convinced should be done away with, but that's another issue?), when they weren't actually necessary for what I was trying to acheive. Unfortunately, I won't be able to give your class a good run in our environment until next week though. But I'll let you know how I got on. One question: Why not just use an AggregatedValidity to store the multiple source validities? I don't understand what benefit you get from using the MultiSourceValidity. Is it the extra checking performed in the switch block inside getValidity(SourceValidity newValidity)? I'm pretty weak on the Source resolving component of Avalon and I must admit I don't understand what is happening here. Finally, about the extra caching going on inside the CIncludeTransformer: What is the name of the class in the scratchpad area you refer to? Thanks again for your help! Ollie
