Joerg Heinicke wrote:

Juan Jose Pablos <cheche <at> apache.org> writes:



Hi,
I think that it would be nice to add half line text on the deprecated section on blocks.properties to point out what is the block replacement.


Please apply this patch.



blocks.properties is auto-generated, so a commit of the patch makes no sense. It would be a useful addition to gump.xml though, so that the comment could be generated too.



I did not know that it was created with a stylesheet, anyway, this patch allows use the @description just on the deprecated elements. Is that ok then?


Cheers, Cheche

Index: gump2blocks.properties.xsl
===================================================================
--- gump2blocks.properties.xsl	(revisiĆ³n: 125165)
+++ gump2blocks.properties.xsl	(copia de trabajo)
@@ -120,6 +120,11 @@
 </xsl:template>
 
 <xsl:template match="project">
+    <xsl:if test="@status='deprecated'">
+      <xsl:text>#</xsl:text>
+      <xsl:copy-of select="description"/>
+      <xsl:text>&#10;</xsl:text>
+    </xsl:if>
     <xsl:call-template name="dependency">
         <xsl:with-param name="elements" select="depend[starts-with(@project, 'cocoon-block-')]"/>
         <xsl:with-param name="text" select="'depends on'"/>
@@ -161,5 +166,4 @@
         <xsl:otherwise>,</xsl:otherwise>
     </xsl:choose>
 </xsl:template>
-
 </xsl:stylesheet>
Index: gump.xml
===================================================================
--- gump.xml	(revisiĆ³n: 125165)
+++ gump.xml	(copia de trabajo)
@@ -289,6 +289,7 @@
   </project>
 
   <project name="cocoon-block-portal-fw" status="deprecated">
+    <description>Deprecated use portal instead</deprecated>
     <package>org.apache.cocoon</package>
 
     <ant target="gump-block">
@@ -753,6 +754,7 @@
   </project>
 
   <project name="cocoon-block-woody" status="deprecated">
+    <description>Deprecated use forms instead</deprecated>
     <package>org.apache.cocoon</package>
 
     <ant target="gump-block">

Reply via email to