Daniel Fagerstrom wrote:

Ok, only the InstructionFactory is a component, that is better. Is there any point in leting the InstructionFactory be a component?
Only the fact that I had to store the configuration somewhere and with cocoon.xconf I had the proper tools at hand.

As said I would prefer template configuration in a separate file. Also I don't like the repetition of the target name space, we could declare that in a enclosing tag e.g. "instructions".
Like:
<instructions targetNamespace="jx">
  <instruction name="for" class="StartFor"/>
  <instruction name="for" class="StartFor"/>
  <instruction name="for" class="StartFor"/>
</instructions>
<instructions targetNamespace="ft">
  <instruction name="widget" class="StartWidget"/>
</instructions>
?

Fine for me.

Do you have any proposal how could we create an extendable instruction configuration that could be extended by another block?

Might be, but I just don't feel like participating in any more taglib discussions.

OT: I'd like to rename o.a.c.template.jxtg.script.event.StartInstruction into o.a.c.template.jxtg.script.instruction.Instruction. The name was good internally. If ever any other block implemented a new Instruction it is kind of weird to implement "StartInstruction"..


Sure, just go ahead. I would even prefer o.a.c.template.script.instruction.Instruction as it shoulddn't have anything to do with JXTG.
It looks like jxtg part could be dropped from:

o.a.c.template.jxtg
o.a.c.template.jxtg.environment
o.a.c.template.jxtg.expression
o.a.c.template.jxtg.instruction
o.a.c.template.jxtg.script
o.a.c.template.jxtg.script.event

there is no single o.a.c.template.SomeClas

WDYT?
--
Leszek Gawron                                      [EMAIL PROTECTED]
IT Manager                                         MobileBox sp. z o.o.
+48 (61) 855 06 67                              http://www.mobilebox.pl
mobile: +48 (501) 720 812                       fax: +48 (61) 853 29 65

Reply via email to