[EMAIL PROTECTED] wrote:

Author: jheymans
Date: Thu Oct  6 01:27:55 2005
New Revision: 306551

URL: http://svn.apache.org/viewcvs?rev=306551&view=rev

--- 
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Repeater.java 
(original)
+++ 
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/formmodel/Repeater.java 
Thu Oct  6 01:27:55 2005
+    public void generateValidationMessage(ContentHandler contentHandler) 
throws SAXException {
+        if (validationError != null ) {
+            contentHandler.startElement(Constants.INSTANCE_NS, 
REPEATER_VALIDATION_MESSAGE_EL, Constants.INSTANCE_PREFIX_COLON + 
REPEATER_VALIDATION_MESSAGE_EL, XMLUtils.EMPTY_ATTRIBUTES);
+            this.validationError.generateSaxFragment(contentHandler);
+            contentHandler.endElement(Constants.INSTANCE_NS, 
REPEATER_VALIDATION_MESSAGE_EL, Constants.INSTANCE_PREFIX_COLON + 
REPEATER_VALIDATION_MESSAGE_EL);
+        }
    }


--- 
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/generation/jx-macros.xml 
(original)
+++ 
cocoon/blocks/forms/trunk/java/org/apache/cocoon/forms/generation/jx-macros.xml 
Thu Oct  6 01:27:55 2005
@@ -77,7 +77,16 @@
+
+    <!--
+        ft:repeater-validation-error
+    -->
+    <jx:macro name="repeater-validation-message" 
targetNamespace="http://apache.org/cocoon/forms/1.0#template";>
+      <jx:parameter name="id"/>
+
+      <jx:set var="cformsDummy" 
value="${cformsHelper.generateRepeaterValidationMessage(widget, id)}"/>
+    </jx:macro>
+

I would like to avoid instruction proliferation in the template language. We already have <ft:validation-error> that does the exact same job.

Any objection for me to remove <ft:repeater-validation-message> (I'm ready to commit!)?

Sylvain

--
Sylvain Wallez                        Anyware Technologies
http://people.apache.org/~sylvain     http://www.anyware-tech.com
Apache Software Foundation Member     Research & Technology Director

Reply via email to