[ http://issues.apache.org/jira/browse/COCOON-1758?page=comments#action_12427261 ] Simone Gianni commented on COCOON-1758: ---------------------------------------
The code in jx-macros actually calls cocoon.parameter.getParameter('locale'). Unfortunately, if a locale is not specified, this brings to an exception, since a default value is not given. This beaks compatibility with previous 2.1 versions, and in general IMMO having to specify explicitly a local for every form template is verbose. I think this should be substituted with getParameter('locale',null), and subseguently in the JXMacrosHelper the given locale must be used, if present, otherwise the request one, otherwise the default one. I have this fix on my version, but wanted to know if this is the intended behaviour before committing. > Form locale never used in JXMacros > ---------------------------------- > > Key: COCOON-1758 > URL: http://issues.apache.org/jira/browse/COCOON-1758 > Project: Cocoon > Issue Type: Bug > Components: Blocks: Forms > Affects Versions: 2.1.8, 2.2-dev (Current SVN), 2.1.9 > Reporter: Philippe Gassmann > Assigned To: Antonio Gallardo > Fix For: 2.2-dev (Current SVN), 2.1.10-dev (current SVN) > > Attachments: 20060201-cocoon-forms-1758, patch.txt, patch1.txt > > > The JXMacroHelper is created with : <jx:set var="cformsHelper" > value="#{org.apache.cocoon.forms.generation.JXMacrosHelper.createHelper($cocoon/consumer,$cocoon/request,$cocoon/parameters/locale)}"/> > So the locale is get from sitemap parameters. > the locale attribute of the form is then never used. > I will provide a patch as soon as possible -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira