[Patch] RequestProcessor swallows exceptions in blocks case
-----------------------------------------------------------

                 Key: COCOON-1954
                 URL: http://issues.apache.org/jira/browse/COCOON-1954
             Project: Cocoon
          Issue Type: Bug
          Components: * Cocoon Core, - Blocks Framework
    Affects Versions: 2.2-dev (Current SVN)
            Reporter: Alexander Klimetschek
         Attachments: 
cocoon-request-processor-swallows-exceptions-for-blocks.patch

While updating to the latest Cocoon I stepped into the problem that you cannot 
see the exceptions thrown in a BlockServlet called by another one, since the 
new refactored RequestProcessor swallows all exceptions. The generated error 
page is fed into the response output stream which is eventually read by 
anything in the calling pipeline, which mostly cannot handle that html error 
page (in my case it gets some xml) and will throw another exception like 
SAXParseException.

This patch adds a boolean rethrowExceptions() method to the RequestProcessor 
that is used inside service() to check whether a catched exception should be 
rethrown. The standard return value is false, in the subclass 
o.a.c.sitemap.SitemapServlet$RequestProcessor it returns true so that the 
exception is passed on to the "root" sitemap (handling the servletrequest that 
actually comes from a browser or so) which will eventually create the error 
page.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to