[
https://issues.apache.org/jira/browse/COCOON-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12502127
]
Daniel Fagerstrom commented on COCOON-2066:
-------------------------------------------
Great that you are working on it.
Considering the setRequest method I think it makes sense to use
HttpServletRequest as neither Cocoon nor any other conceivable servlet based
webapp will have any use for requests that only implement ServletRequest (which
among many other things lacks context and servlet paths). So IMO it is better
to down cast to the arguments to the forward method and fail as fast as
possible in the unlikely situation that the arguments doesn't implement
HttpServlet[Request|Response].
> BlockCompletePathModule returns wrong path in scope of internal servlet call
> ----------------------------------------------------------------------------
>
> Key: COCOON-2066
> URL: https://issues.apache.org/jira/browse/COCOON-2066
> Project: Cocoon
> Issue Type: Bug
> Components: - Servlet service framework
> Affects Versions: 2.2-dev (Current SVN)
> Reporter: Grzegorz Kossakowski
> Assignee: Grzegorz Kossakowski
>
> BlockCompletePathModule uses this construct:
> public Object getAttribute(String name, Configuration modeConf, Map
> objectModel) throws ConfigurationException {
> return ObjectModelHelper.getRequest(objectModel).getContextPath() +
> blockPathModule.getAttribute(name, modeConf, objectModel);
> }
> However, when internal (service call or not) request is being made
> BlockCallHttpServletRequest becomes an object represnting current request but
> it has no meaningful representation of getContextPath method.
> Solution to this problem might be forwarding context path value from original
> request.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
