Vadim Gritsenko pisze: > On Dec 19, 2007, at 8:24 AM, Carsten Ziegeler (JIRA) wrote: > >> [ >> https://issues.apache.org/jira/browse/COCOON-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553359 >> ] >> >> Carsten Ziegeler commented on COCOON-2150: >> ------------------------------------------ >> >> Looking again at the code, I guess that the problematic part is the >> check of the status code in ServletServiceContext.java:575. >> >> If an error handler has been running it might have set the error code >> to 500. >> >> I'm wondering why this status code checking is done anyway? > > Nod. It is all very smelly. Imagine if you were trying to send status > 100 or 401...
The check has been introduced in order to handle polymorphism of servlet services but it seems that I overlooked mentioned snippet. Certainly we need to check HTTP specification and make this check more clever if we want to receive expected behaviour. I'll have a look on this ASAP. My personal TODO list is: 1. Document servlet services 2. Have a look at COCOON-2126. 3. Evaluate patch in COCOON-1831 4. Now it's time to add COCOON-2150 to this list ;) I'm leaving Warsaw tomorrow and moving back to my parents. I'm sure that I will find enough amount of peace in a village of Eastern Poland to handle my TODO list... -- Grzegorz Kossakowski Committer and PMC Member of Apache Cocoon http://reflectingonthevicissitudes.wordpress.com/
