Ack. My filter ate this conversation; sorry for not seeing it earlier. This is my new machine and I forgot to twiddle the svn props. I'll get that sorted out.
On 10/18/07, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > On 10/18/07, Rahul Akolkar <[EMAIL PROTECTED]> wrote: > > On 10/17/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > Author: bspeakmon > > > Date: Wed Oct 17 17:11:37 2007 > > > New Revision: 585762 > > > > > > URL: http://svn.apache.org/viewvc?rev=585762&view=rev > > > Log: > > > - first crack at generic IP address validator > > > > > > Added: > > > > commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java > > > > commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/InetAddressValidatorTest.java > > > > > <snip/> > > > > Missing svn props. > > +1, especially the eol:style which should be set to "native" otherwise > if people using different operating systems (e.g. Windoze, Linux) > modify the same file then alot of "noise" gets created with every line > being flagged as changed because of the line endings. > > You can configure your svn client's auto-props to automatically set a > set of default properties so that when you add new artifacts you don't > have to remember to set them > > For example, something lile > > [auto-props] > *.java = svn:eol-style=native;svn:keywords=Date Author Id Revision HeadURL > *.xml = svn:eol-style=native;svn:keywords=Date Author Id Revision HeadURL > *.txt = svn:eol-style=native;svn:keywords=Date Author Id Revision HeadURL > *.properties = svn:eol-style=native > *.html = svn:eol-style=native;svn:mime-type=text/html > > Also my preference is to use Jira to track all changes and reference > the Jira issue number in the commit message - that way its easy to > find all discussion, commits etc in one place - and easier to manage > releases/versions. I've created one for this change here: > > https://issues.apache.org/jira/browse/VALIDATOR-241 > > Niall > > P.S. InetAddressValdiator looks good - thanks :) > > > -Rahul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
