Oliver Heger wrote:
> Hi Jörg,
>
> thanks for the comments.
>
> Jörg Schaible wrote:
>> Hi Oliver,
>>
> <snip/>
>>
>> src package compiles and runs tests on my compiler zoo, fine!
>>
>> Dependencies:
>> - pom uses commons-logging:commons-logging-api instead of
>> commons-logging:commons-logging. The API version should only be used when
>> building a server like Tomcat (IIRC)
>> - because of this we have both commons-logging-api-1.0.4 and
>> commons-logging-1.1 (as transitive dep from digester) in the classpath.
>> Maybe we should directly upgrade to 1.1.1 to drop the optional deps of
>> JCL
> 1.1.1 is not available yet. Would it help to upgrade to 1.1 in the
> meantime?
Oh, well, since we already voted, I thought it had happened :)
Dennis, any time frame?
JCL 1.1 declares compile-time deps to avalon-framework, log4j, logkit and
javax.servlet:servlet-api. We can exlude them (or redeclare them as
optional/provided in case of avalon-framework and servlet-api).
>> - commons-jxpath triggers old xerces-1.2.3, ant-optional and jdom. At
>> least the first two should be possibly excluded, especially since the
>> dependencies page refers xerces-2.2.0 and the pom refers an optional
>> ant-1.6.5
> How can this be achieved? The dependency to jxpath has already been
> marked as optional. What further steps need to be performed?
xerces:xerces should be excluded, since JCC refers newer artifacts of xerces
(with different groupId)
ant-optional possibly also, unfortunately this artifact not even exists in
1.6.x series since it has been splitted.
Current deps:
[EMAIL PROTECTED] ~/java/commons-configuration-1.5-src $ mvn info:deps-test
[INFO] Scanning for projects...
[INFO] Searching repository for plugin with prefix: 'info'.
[INFO]
----------------------------------------------------------------------------
[INFO] Building Commons Configuration
[INFO] task-segment: [info:deps-test]
[INFO]
----------------------------------------------------------------------------
[WARNING] POM for 'commons-codec:commons-codec:pom:1.3:compile' is invalid.
It will be ignored for artifact resolution. Reason: Failed to validate POM
[WARNING]
Artifact xml-apis:xml-apis:jar:1.0.b2:provided retains local
scope 'provided' overriding broader scope 'compile'
given by a dependency. If this is not intended, modify or remove the
local scope.
[WARNING]
Artifact junit:junit:jar:3.8.1:test retains local scope 'test'
overriding broader scope 'compile'
given by a dependency. If this is not intended, modify or remove the
local scope.
[INFO] [info:deps-test]
[INFO] commons-configuration:commons-configuration:jar:1.5
[INFO] commons-collections:commons-collections:jar:3.2
[INFO] mockobjects:mockobjects-jdk1.4-j2ee1.3:jar:0.09
[INFO] dbunit:dbunit:jar:2.1
[INFO] commons-lang:commons-lang:jar:2.3
[INFO] junit-addons:junit-addons:jar:1.4
[INFO] : xerces:xmlParserAPIs:jar:2.6.2
[INFO] ant:ant:jar:1.6.5
[INFO] commons-jxpath:commons-jxpath:jar:1.2
[INFO] : xerces:xerces:jar:1.2.3
[INFO] : ant:ant-optional:jar:1.5.1
[INFO] : jdom:jdom:jar:b9
[INFO] commons-digester:commons-digester:jar:1.8
[INFO] : commons-logging:commons-logging:jar:1.1
[INFO] : logkit:logkit:jar:1.0.1
[INFO] : log4j:log4j:jar:1.2.12
[INFO] : avalon-framework:avalon-framework:jar:4.1.3
[INFO] javax.mail:mail:jar:1.4
[INFO] : javax.activation:activation:jar:1.1
[INFO] xml-apis:xml-apis:jar:1.0.b2
[INFO] junit:junit:jar:3.8.1
[INFO] javax.servlet:servlet-api:jar:2.4
[INFO] commons-logging:commons-logging-api:jar:1.0.4
[INFO] xerces:xercesImpl:jar:2.3.0
[INFO] commons-pool:commons-pool:jar:1.1
[INFO] commons-beanutils:commons-beanutils:jar:1.7.0
[INFO] mockobjects:mockobjects-core:jar:0.09
[INFO] commons-codec:commons-codec:jar:1.3
[INFO] hsqldb:hsqldb:jar:1.7.2.2
[INFO] xalan:xalan:jar:2.7.0
[INFO] commons-dbcp:commons-dbcp:jar:1.2.2
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
Applying this patch:
==================== %< ================
[EMAIL PROTECTED] ~/java/commons-configuration-1.5-src $ diff -u pom.xml pom.new
--- pom.xml 2007-11-01 15:13:40.000000000 +0100
+++ pom.new 2007-11-05 22:12:41.546284773 +0100
@@ -202,8 +202,23 @@
<dependency>
<groupId>commons-logging</groupId>
- <artifactId>commons-logging-api</artifactId>
- <version>1.0.4</version>
+ <artifactId>commons-logging</artifactId>
+ <version>1.1</version>
+ <!-- remove exclusions for JCL 1.1.1 -->
+ <exclusions>
+ <exclusion>
+ <groupId>logkit</groupId>
+ <artifactId>logkit</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>avalon-framework</groupId>
+ <artifactId>avalon-framework</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
@@ -230,6 +245,16 @@
<artifactId>commons-jxpath</artifactId>
<version>1.2</version>
<optional>true</optional>
+ <exclusions>
+ <exclusion>
+ <groupId>xerces</groupId>
+ <artifactId>xerces</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ant</groupId>
+ <artifactId>ant-optional</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
@@ -311,6 +336,12 @@
<artifactId>junit-addons</artifactId>
<version>1.4</version>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>xerces</groupId>
+ <artifactId>xmlParserAPIs</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
==================== %< ================
You end up with this deps:
[EMAIL PROTECTED] ~/java/commons-configuration-1.5-src $ mvn -f pom.new
info:deps-test
[INFO] Scanning for projects...
[INFO] Searching repository for plugin with prefix: 'info'.
[INFO]
----------------------------------------------------------------------------
[INFO] Building Commons Configuration
[INFO] task-segment: [info:deps-test]
[INFO]
----------------------------------------------------------------------------
[WARNING] POM for 'commons-codec:commons-codec:pom:1.3:compile' is invalid.
It will be ignored for artifact resolution. Reason: Failed to validate POM
[WARNING]
Artifact xml-apis:xml-apis:jar:1.0.b2:provided retains local
scope 'provided' overriding broader scope 'compile'
given by a dependency. If this is not intended, modify or remove the
local scope.
[WARNING]
Artifact junit:junit:jar:3.8.1:test retains local scope 'test'
overriding broader scope 'compile'
given by a dependency. If this is not intended, modify or remove the
local scope.
[INFO] [info:deps-test]
[INFO] commons-configuration:commons-configuration:jar:1.5
[INFO] commons-collections:commons-collections:jar:3.2
[INFO] mockobjects:mockobjects-jdk1.4-j2ee1.3:jar:0.09
[INFO] dbunit:dbunit:jar:2.1
[INFO] commons-lang:commons-lang:jar:2.3
[INFO] junit-addons:junit-addons:jar:1.4
[INFO] commons-jxpath:commons-jxpath:jar:1.2
[INFO] : jdom:jdom:jar:b9
[INFO] ant:ant:jar:1.6.5
[INFO] commons-digester:commons-digester:jar:1.8
[INFO] javax.mail:mail:jar:1.4
[INFO] : javax.activation:activation:jar:1.1
[INFO] xml-apis:xml-apis:jar:1.0.b2
[INFO] junit:junit:jar:3.8.1
[INFO] javax.servlet:servlet-api:jar:2.4
[INFO] xerces:xercesImpl:jar:2.3.0
[INFO] commons-pool:commons-pool:jar:1.1
[INFO] commons-beanutils:commons-beanutils:jar:1.7.0
[INFO] mockobjects:mockobjects-core:jar:0.09
[INFO] commons-codec:commons-codec:jar:1.3
[INFO] commons-logging:commons-logging:jar:1.1
[INFO] hsqldb:hsqldb:jar:1.7.2.2
[INFO] commons-dbcp:commons-dbcp:jar:1.2.2
[INFO] xalan:xalan:jar:2.7.0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1 second
[INFO] Finished at: Mon Nov 05 22:14:25 CET 2007
[INFO] Final Memory: 2M/5M
[INFO] ------------------------------------------------------------------------
The only difference running the tests with Maven now is that exception's
stack trace is printed to the screen instead of written into a log file
(because of the now missing log4j dependency).
>> Site glitches:
>> - broken link in "Howtos (1.2 release)" exists a broken link to the
>> current "User's Guide"
>> - download page has no entry for version 1.5 (yet ?)
>> - changes state version 1.5 to be in SVN ... don't forget entry in POM
> This is a problem of our release process because I cannot anticipate the
> real release date. So I intend to fill the date in before the final site
> gets deployed. But of course I must not forget this.
I thought so ;-)
>> - findbugs report ... open issues ??
> The majority of these issues refers to generated code in the plist
> package. I will try to find a way how these classes can be excluded.
OK. I was not aware that the criticized code has been generated.
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
