Niall Pemberton wrote:
On Nov 19, 2007 10:31 PM, Dennis Lundberg <[EMAIL PROTECTED]> wrote:
Three things:
1. Why change the versioning scheme for the skin? ( 1.1-SNAP -> 2-SNAP )
Do you feel that it is more like a parent pom than a component? The
skins that are maintained by the Maven project use x.y.x versions.
Yes it seemed more in keeping with commons-parent and x.y.x versioning
scheme has meaning wrt to bug bugs/improvements/compatibility that
don't IMO relate really to the skin. But if you don't like it then
feel free to change it back.
No, I was just wondering...
2. Did you mean to remove the license from site.css?
Yes, it didn't make any sense to me having a css file which only
contains a copyright notice - it was copyrighting nothing!!! I
actually added one line, but I don't believe that (i.e. one statement
importing another css) has anything that is copyrightable either. In
the source file header FAQ[1] it says:
"What files in an Apache release do not require a license header?
A file without any degree of creativity in either its literal elements
or its structure is not protected by copyright law; therefore, such a
file does not require a license header. If in doubt about the extent
of the file's creativity, add the license header to the file."
[1] http://www.apache.org/legal/src-headers.html
Thanks for that reference! I've been wondering sometimes where to draw
the line.
3. Would you mind deploying a SNAPSHOT of the new version of the skin so
that people can use without having to build it.
Sure although perhaps would be better to just release it? Where do we
deploy snapshots and can I do it through m2 (if so how?) or is just
manual upload best way?
A simple 'mvn deploy' is all it takes. No manual uploading is required.
That is under normal circumstances. But, because someone (don't know
who) added the dummy repository to the commons-parent, you have to do
'mvn -Prc deploy' for snapshot deployment. I don't understand why this
was done, but I'll start a different thread about that.
Niall
Thanks
[EMAIL PROTECTED] wrote:
Author: niallp
Date: Fri Nov 16 08:22:19 2007
New Revision: 595723
URL: http://svn.apache.org/viewvc?rev=595723&view=rev
Log:
Change skin sit.css to import http://commons.apache.org/style/commons-maven.css
Modified:
commons/proper/commons-skin/trunk/pom.xml
commons/proper/commons-skin/trunk/src/main/resources/css/site.css
Modified: commons/proper/commons-skin/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/commons/proper/commons-skin/trunk/pom.xml?rev=595723&r1=595722&r2=595723&view=diff
==============================================================================
--- commons/proper/commons-skin/trunk/pom.xml (original)
+++ commons/proper/commons-skin/trunk/pom.xml Fri Nov 16 08:22:19 2007
@@ -20,10 +20,10 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>1</version>
+ <version>5</version>
</parent>
<artifactId>commons-skin</artifactId>
- <version>1.1-SNAPSHOT</version>
+ <version>2-SNAPSHOT</version>
<name>Commons Skin</name>
<description>Commons Skin</description>
<scm>
Modified: commons/proper/commons-skin/trunk/src/main/resources/css/site.css
URL:
http://svn.apache.org/viewvc/commons/proper/commons-skin/trunk/src/main/resources/css/site.css?rev=595723&r1=595722&r2=595723&view=diff
==============================================================================
--- commons/proper/commons-skin/trunk/src/main/resources/css/site.css (original)
+++ commons/proper/commons-skin/trunk/src/main/resources/css/site.css Fri Nov
16 08:22:19 2007
@@ -1,16 +1 @@
-/*
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
- http://www.apache.org/licenses/LICENSE-2.0
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
-*/
[EMAIL PROTECTED] url("http://commons.apache.org/style/commons-maven.css";);
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
