>
> input/output errors.
>>
> I agree with Torsten. There may occur other exceptions than plain
>
> I looked at the code, indeed the exceptions in the refactored compress are
> always related to configuration issue, whereas in the current svn code
> errors are often created on IO issues (path not writable, file is not a
> directory, etc).
>

ah right, the svn-version is more file oriented, that maybe would make sense
there.


>
> Btw, regading this code in ArchiveStreamFactory :
>
>    if (clazz == null) {
>        throw new ArchiveException("ArchiverFactory could not create
> instance");
>    }
>
> Shouldn't this throw a NullPointerException instead ?
>

I would like to be carefully with throwing NullPointerException. In that
case we simply
wouldn't find a matching implementation - i think a better message but still
archiveexception
will do fine.

If that params:
final String archiverName, final InputStream out
would be null, i would agree with a NullPointerException. Thanks for the
hint.

Best,
chris


>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to