On 22/02/2009, pste...@apache.org <pste...@apache.org> wrote: > Author: psteitz > Date: Sun Feb 22 23:43:52 2009 > New Revision: 746849 > > URL: http://svn.apache.org/viewvc?rev=746849&view=rev > Log: > Added a connectionInitSqls configuration parameter to BasicDataSource > allowing > the user to specify a collection of SQL statements to execute one time when > a physical database connection is first opened. > JIRA: DBCP-175 > Thanks to Jiri Melichna and Jerome Lacoste. > > > Modified: > > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java > > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSourceFactory.java > > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java > > commons/proper/dbcp/trunk/src/java/org/apache/commons/jocl/JOCLContentHandler.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSource.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestBasicDataSourceFactory.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterStatement.java > > commons/proper/dbcp/trunk/src/test/org/apache/commons/jocl/TestJOCLContentHandler.java > commons/proper/dbcp/trunk/src/test/testpool.jocl > commons/proper/dbcp/trunk/xdocs/changes.xml > commons/proper/dbcp/trunk/xdocs/configuration.xml > > Modified: > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java > URL: > http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java?rev=746849&r1=746848&r2=746849&view=diff > > ============================================================================== > --- > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java > (original) > +++ > commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java > Sun Feb 22 23:43:52 2009 > @@ -19,6 +19,11 @@ > > import java.io.PrintWriter; > import java.util.Properties; > +import java.util.Collection; > +import java.util.List; > +import java.util.ArrayList; > +import java.util.Iterator; > +import java.util.Collections; > import java.sql.Connection; > import java.sql.Driver; > import java.sql.DriverManager; > @@ -801,6 +806,60 @@ > } > this.restartNeeded = true; > } > + > + /** > + * These SQL statements run once after a Connection is created. > + * <p> > + * This property can be used for example to run ALTER SESSION SET > + * NLS_SORT=XCYECH in an Oracle Database only once after connection > + * creation. > + * </p> > + * > + * @since 1.3 > + */ > + protected List connectionInitSqls; > +
Why protected and not private? This allows sub-classes to break the thread-safety provided by the synch. get and set methods. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
