On 18/03/2009, Stefan Bodewig <bode...@apache.org> wrote: > On 2009-03-18, Stefan Bodewig <bode...@apache.org> wrote: > > > I'd like to remove some fields, make them private or final and maybe > > move some methods around before our first release. In particular: > > > I just saw sebb's patch attached to SANDBOX-294 and he seems to agree > with most of my points.
Yes - start with no non-private mutable variables (hopefully keep it that way), and only make methods non-private if they are needed for the API or the class hierarchy. > In addition the patch makes some package > private fields bzip2 private - which I think is a a good idea as well. > > > Stefan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
