sebb wrote:
On 31/05/2009, Phil Steitz <phil.ste...@gmail.com> wrote:
s...@apache.org wrote:
Thanks!
- for (int i = 0; i < 4; i++) {
+ for (int i = 0; i < smallPrimes.length; i++) {
pool.setNumTestsPerEvictionRun(smallPrimes[i]);
- for (int j = 0; j < 5; j++) {
+ for (int j = 0; j < 5; j++) { // TODO why 5?
No particular reason to choose 5 here - that is just the number of random
pool-generation-then-visiting iterations to perform. Could make this a
constant, but it is only used here.
OK. I just wondered if it was related to 4==smallPrimes.length.
Perhaps it might be worth making it the outer loop?
Could then make it a variable, e.g. derived from a property, with
default value 5.
This could make the current debugging a bit easier, as we could use a
larger number.
+1
Phil
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
