Hi Emmanuel, see my comments below ...
Cheers, Siegfried Goeschl Emmanuel Bourg wrote: > A few comments: > > - 1.0-rc6-SNAPSHOT is still mentioned as "in svn" in the change notes. > I guess the changes for the two 1.0-rc could be merged into the > changes for 1.0 I guess that would be bending old release notes I have not written so I'm not eager to do that ... > > - Commons Logging is listed in the test dependencies, but it's not used commons-logging-1.1 is a transitive dependency of SubEtha SMTP Wiser and overwritten with 1.1.1 - but the test also work with commons-logging-1.1 so the dependency is not needed > > - the clirr report is generated against Commons Email 1.0, not 1.1 This was intentional since I would need two reports - so is it better to compare the APIs against the first major release or the last minor release? > > - the release notes state "Commons Email requires JavaMail 1.4 or > later. The *proprietary* Sun implementation is available at", but > JavaMail is open source since march. The whole section could probably > be reworded. Yep, that's right - need to update the release notes > > Emmanuel Bourg > > > Siegfried Goeschl a écrit : >> Hi folks, >> >> I would like to call a vote for releasing commons-email-1.2 based on >> RC2. >> >> This release candidate has the following changes compared to RC1 >> >> +) using "http://example.invalid"; for a bad url >> +) avoid using java.net.URL.equals(Object) which blocks to do domain >> name resolution >> +) removed all of the M1 left-overs and updated the assembly descriptors >> +) added the minimum JDK requirement to the index page >> +) the regression tests now work without internet connectivity >> >> >> Tag: >> >> https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_2 >> >> Site: >> >> http://people.apache.org/builds/commons/email/1.2/RC2/site/index.html >> >> Binaries: >> >> http://people.apache.org/builds/commons/email/1.2/RC2/staged/commons-email/commons-email/1.2/ >> >> >> [ ] +1 release it >> [ ] +0 go ahead I don't care >> [ ] -1 no, do not release it because >> >> Thanks in advance >> >> Siegfried Goeschl >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
