Mark Thomas wrote:
> sebb wrote:
>> Findbugs has lots of complaints that the DelegatingDatabaseMetaData
>> class methods may return null for methods which should be @NonNull.
>>
>> These are all of the form:
>>
>> public String getSchemaTerm() throws SQLException {
>> { try { return _meta.getSchemaTerm(); }
>> catch (SQLException e) { handleException(e); return null; } }
>> }
>>
>> Now the handleException() method never returns, it always throws an
>> exception, so the return statement cannot be reached.
>>
>> Seems to me it would be clearer to replace the return statements with
>> an assertion exception.
>>
>> WDYT?
>
> +1
>
> Mark
+1
Phil
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
