sebb wrote: > On 23/01/2010, Bill Barker <[email protected]> wrote: >> >> -------------------------------------------------- >> From: "sebb" <[email protected]> >> Sent: Friday, January 22, 2010 6:21 AM >> To: "Commons Developers List" <[email protected]> >> Subject: [MATH] Remove unnecessary suite() methods from test classes? >> >> >> >>> There are a lot of src/test classes that contain a suite() method of the >> form: >>> public static Test suite() { >>> TestSuite suite = new >> TestSuite(SparseRealVectorTest.class); >>> suite.setName("SparseRealVector Tests"); >>> return suite; >>> } >>> >>> or >>> >>> public static Test suite() { >>> return new >> TestSuite(TriDiagonalTransformerTest.class); >>> } >>> >>> >>> Seems to me that these methods add little or no benefit to the code, >>> and could just be removed. >>> >>> Any objections? >>> >>> >> +1 >> > > And the result is: > > -suite() > > (they have all gone)
Thanks! Phil > >> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: >> [email protected] >>> For additional commands, e-mail: [email protected] >>> >>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
