On Tue, Feb 23, 2010 at 2:04 AM, sebb <seb...@gmail.com> wrote: > On 20/02/2010, Niall Pemberton <niall.pember...@gmail.com> wrote: >> The commons-build-plugin has been modified to improve the L&F and >> cater for more than one release on the download page. >> >> [ ] +1 Yes go ahead an release based on RC2 >> [ ] -1 No, because... >> >> commons-build-plugin 1.2 RC2 is available for review here: >> http://people.apache.org/~niallp/plugin-1.2-rc2/maven/commons-build-plugin/ >> >> Details of changes since 1.1 are in the release notes: >> http://people.apache.org/~niallp/plugin-1.2-rc2/RELEASE-NOTES.txt >> >> The tag is here: >> >> http://svn.apache.org/viewvc/commons/proper/commons-build-plugin/tags/commons-build-plugin-1.2-RC2/ > > NOTICE file still says: > > Copyright 2008
Doh! Is this a blocker though? IMO no. >> Site: >> http://people.apache.org/~niallp/plugin-1.2-rc2/site/ > > [Just fixed a typo on the index page] > >> RAT Report: >> http://people.apache.org/~niallp/plugin-1.2-rc2/site/rat-report.html > > Shouldn't the XML fragments > download-page-body.xml > download-page-foot.xml > have AL headers? > > I know they are part pages, but they do have non-trivial content. I don't want to put headers on those since it combines those together to create a single XML download page - and having multiple headers would look really rubbish. I also don't agree that these are non-trivial - they are just small XML snippets Niall > Otherwise the artefacts, sigs etc look OK. > >> tia >> >> Niall >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
