On 11/05/2010, Torsten Curdt <[email protected]> wrote: > In the code we call it "Archivername". That should be changed > accordingly to "type" then IMO. (getArchiveName() could be a little > ambiguous) > > That said: Is there a particular reason you need this? Or is this just > because you think it might be useful?
I was thinking it would be useful for the proposed command-line utility - you could pass it any archive file and find out what it is. Also it would be useful for unit tests, to check that the correct type has been detected. [Yes, one check the class name, but that is a bit messy]. > > On Tue, May 11, 2010 at 17:55, sebb <[email protected]> wrote: > > Seems to me that it would be useful to be able to find out what > > ArchiveInputStream has been chosen by the ArchiveStreamFactory. > > > > I'm thinking of adding something like: > > > > public String getArchiveType() { > > return ArchiveStreamFactory.TAR ; // or ZIP etc. > > } > > > > to each of the AIS subclasses. > > > > The AIS parent class could either have a dummy implementation, or the > > parent method could be abstract to force subclasses to provide the > > method. > > > > The same could be done for CompressorStreamFactory. > > > > Thoughts? > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
