ok, i will try to finish these jobs as soon as possible -Gui Xun Long
On 5/19/10, Rahul Akolkar <[email protected]> wrote: > On Wed, May 19, 2010 at 10:08 AM, sebb <[email protected]> wrote: >> On 19/05/2010, Xun Long Gui <[email protected]> wrote: >>> Hi, >>> >>> They are all GMF standard file format, they are very important for >>> this project. As you say, they are xml file indeed, but we can not >>> change their extensions to .xml >> >> OK, then please add the extensions to your SVN configuration (so >> future files will have the property added automatically), and add the >> eol-style SVN property to the current files - thanks! >> > <snip/> > > +1 > > For example, at the command line, in the appropriate directory of your > working copy: > > svn propset svn:eol-style "native" scxml.ecore > > Similarly for the rest of the files identified below. This will reduce > noise in the diffs when these files are updated. > > Also, please add to the README (or another suitable file in the > sdocbook directory), a small introduction assuming the reader is > completely new to EMF and GMF-based editors. This could be as simple > as URLs to the Eclipse EMF, GMF project sites and relevant tutorials. > Reading it and the resources pointed to by the URLs, it should be > possible to understand these files and the code, understand which > parts are authored, which are generated and how etc. Again, this can > be quite brief (by virtue of pointing to other URLs). Thanks! > > -Rahul > > >>> >>> -Gui Xun Long >>> >>> >>> On 5/19/10, sebb <[email protected]> wrote: >>> > On 19/05/2010, Rahul Akolkar <[email protected]> wrote: >>> >> Some miscellaneous notes: >>> >> >>> >> 1) A small number of files don't have svn:eol-style set. This isn't >>> >> surprising given some of the uncommon file extensions that are >>> almost >>> >> guaranteed to not be in the auto-props :-) sebb has a script to >>> >> identify these, maybe at some point he'll kindly run it for us. >>> > >>> > # Unknown file types (count) >>> > # ecore 1 >>> > # ecore_diagram 1 >>> > # genmodel 1 >>> > # gmfgen 1 >>> > # gmfgraph 1 >>> > # gmfmap 1 >>> > # gmftool 1 >>> > >>> > Are all of these standard extensions? >>> > Or are some of them invented just for the project? >>> > >>> > It looks like these are all xml files, so perhaps they could have .xml >>> > extensions? >>> > >>> > >>> >> 2) The question of how much generated code needs to be in SVN. We >>> can >>> >> punt on this for now, I'd haven't taken a good look at the code yet. >>> >> >>> >> 3) Some license headers in the generated code were removed with >>> >> today's package renaming since the code was regenerated, other files >>> >> never had it. Suggestion would be to perhaps wait until things have >>> >> stabilized a bit in SVN and then add all missing headers in one >>> swoop. >>> >> >>> >> -Rahul >>> >> >>> >>> >>> -- >>> Best Regards >>> >>> Gui Xun Long (桂训龙) >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Best Regards Gui Xun Long (桂训龙) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
