On 9 August 2010 04:08, James Carman <ja...@carmanconsulting.com> wrote: > On Sun, Aug 8, 2010 at 10:51 PM, sebb <seb...@gmail.com> wrote: >> >> Although the compiler changes varargs into String[] arrays, the two >> tests are not equivalent. >> >> Using varargs exclusively can hide bugs. >> >> For example, method(String, String[]) is not the same as method(String ...). >> > > We're talking about specifically the code I checked in. I believe I'm > exercising the implementation of the methods exactly the same as it > was before. It's just being called differently (using varargs).
IMO the tests are now less stringent, e.g. they no longer distinguish leading string parameters from varargs when calling StringUtils.startsWithAny. As I wrote before, by all means add new vararg tests, but dropping existing tests does not make sense to me. > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
