Luc Maisonobe wrote: > Hi all, > > I have started integrating the FastMath class from MATH-375. I have not > committed anything for now as I am first fixing numerous checkstyle > errors (more than 300) and wanted to have one clean commit to simplify > patching both trunk for 3.0 and branch 2.X. > > One less obvious problem is unit tests. The current tests (which I > converted to Junit 4) depend on a few external classes that themselve > depend on a LGPL library, and this library doesn seem to be available in > maven repositories. This imply that we cannot include the library in the > release, and we cannot either use it as an optional dependency for tests. > > I would suggest to completely remove this library and create tests > simply by storing reference values in files that we would read. It would > be similar to the existing tests for random values or stats. The file > could of course be created using dfp or any other reference high > precision package (having several different reference sources would be > better IMHO). We would remove the random aspect of the tests, which may > or may not be a problem.
Sounds like a reasonable approach. Can you explain a little more what the tests do and what you have in mind in terms of data coverage? In particular, what are the "random aspects" of the tests? I know the answer here is really RTFP (p = patch ;) but hey, I am a little lazy this evening. Phil > > Luc > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
